[Webkit-unassigned] [Bug 129598] Second execution of navigator.vibrate() does not wok.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 9 22:10:25 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=129598





--- Comment #15 from Jinwoo Song <jinwoo7.song at samsung.com>  2014-03-09 22:07:21 PST ---
(From update of attachment 226270)
View in context: https://bugs.webkit.org/attachment.cgi?id=226270&action=review

> Source/WebCore/Modules/vibration/Vibration.cpp:48
>  {

Spec. describes the algorithm for vibrate() method, so it would be better to follow the sequences.
http://www.w3.org/TR/2014/WD-vibration-20140211/

> Source/WebCore/Modules/vibration/Vibration.cpp:51
> +    // And if pattern is an empty list or time is 0, vibration have to be canceled.

s/And if/If

> Source/WebCore/Modules/vibration/Vibration.cpp:57
> +    // Pre-exsiting instance need to be canceled when vibrate() is called also.

Remove 'also'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list