[Webkit-unassigned] [Bug 129807] [Win64] Compile error after r165128.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129807





--- Comment #5 from Mark Lam <mark.lam at apple.com>  2014-03-07 11:11:27 PST ---
(From update of attachment 226133)
View in context: https://bugs.webkit.org/attachment.cgi?id=226133&action=review

> Source/JavaScriptCore/bytecode/Opcode.h:82
> -#if ENABLE(COMPUTED_GOTO_OPCODES)
> +#if ENABLE(COMPUTED_GOTO_OPCODES) || !ENABLE(LLINT_C_LOOP)

Why do you need to add the !ENABLE(LLINT_C_LOOP) conditional?  The 2 seems independent to me.  I think this is not needed.

> Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:96
> +
> +    // The return value is used by the build system to determine if we are building with the C loop backend or the x86 backend.
> +    // See WebKit\Source\JavaScriptCore\JavaScriptCore.vcxproj\LLInt\LLIntAssembly\build-LLIntAssembly.sh
> +
> +#if ENABLE(LLINT_C_LOOP)
>      return 0;
> +#else
> +    return 1;
> +#endif

This feels like a hack because you’re making the LLIntOffsetsExtractor do more than what it is intended to do.  Is there a better way to solve this problem?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.