[Webkit-unassigned] [Bug 129807] [Win64] Compile error after r165128.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129807





--- Comment #4 from peavo at outlook.com  2014-03-07 11:08:40 PST ---
(In reply to comment #3)

Thanks for looking into this :)

> This seems good to me, but someone who works more with the LLINT_C_LOOP would have to review it.  I'm not sure if using the return value of LLIntOffsetsExtractor is the best way to tell if the LLINT_C_LOOP is enabled or if the comment should mention the x86 backend.  This is only for Windows, right?
>

Yes, Windows only.

> The MSVC HAVE_COMPUTED_GOTO change seems a little strange, though.  Did MSVC used to have computed goto and it doesn't anymore, or did it never have computed goto?  Was your r165128 wrong to add this?  Should this be in a separate patch?  It doesn't seem related.

No, MSVC never had it, r165128 added this, but that was wrong.
Win64 failed to compile because of this (when using the label value operator &&), so it is reverted reverted in this patch,
but then Win32 needed some compile fixes, since it had been compiling with HAVE_COMPUTED_GOTO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.