[Webkit-unassigned] [Bug 129807] [Win64] Compile error after r165128.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 7 10:59:49 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=129807





--- Comment #3 from Alex Christensen <alex.christensen at flexsim.com>  2014-03-07 10:56:49 PST ---
This seems good to me, but someone who works more with the LLINT_C_LOOP would have to review it.  I'm not sure if using the return value of LLIntOffsetsExtractor is the best way to tell if the LLINT_C_LOOP is enabled or if the comment should mention the x86 backend.  This is only for Windows, right?

The MSVC HAVE_COMPUTED_GOTO change seems a little strange, though.  Did MSVC used to have computed goto and it doesn't anymore, or did it never have computed goto?  Was your r165128 wrong to add this?  Should this be in a separate patch?  It doesn't seem related.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list