[Webkit-unassigned] [Bug 129869] [GTK] Runtime error when page is closed while print operation is in progress

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129869


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andersca at apple.com




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-03-07 09:52:09 PST ---
(In reply to comment #2)
> (From update of attachment 226099 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=226099&action=review
> 
> GTK+ bits look good to me. I'll leave the rest to the WebKit2 owners.

Thanks for the review.

> > Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:418
> > +void WebPrintOperationGtk::disconnectFromPage()
> 
> Maybe call this didDisconnectFromPage or notifyDisconnectFromPage since the disconnection actually happens earlier?

I followed other similar existing methods that are disconnectFromPage. This happens when the page is closed, and is telling the print operation to disconnect from the page. It's consistent with WebColorChooser::disconnectFromPage(), WebPopupMenu::disconnectFromPage(), WebOpenPanelResultListener::disconnectFromPage(), etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.