[Webkit-unassigned] [Bug 129884] New: Make Math.imul ES6 conform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129884

           Summary: Make Math.imul ES6 conform
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tmeszaros.u-szeged at partner.samsung.com
                CC: darin at apple.com, ggaren at apple.com, oliver at apple.com,
                    ossy at webkit.org, mhahnenberg at apple.com


I had made some test about the current solution of this method, and I had found some problem with it:

The standard say:

- Let a be ToUint32(x).  >> the current conversion is: ToInt32(x)
- ReturnIfAbrupt(a).
- Let b be ToUint32(y). >> the current conversion is: ToInt32(x)
- ReturnIfAbrupt(b). >> there is no check for it.
- Let product be (a × b) modulo 2^32. >> the current count is: (a x b)
- If product ≥ 2<<31, return product − 2<<32, otherwise return product.

Failed test:

- If the second parameter is an exception, it will follow run, and try to do the (a x b), but it cant. So it must return after the thrown exception, instead of follow with next step.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.