[Webkit-unassigned] [Bug 34189] check-webkit-style failed to complain about missing braces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34189





--- Comment #4 from László Langó <llango.u-szeged at partner.samsung.com>  2014-03-06 01:51:50 PST ---
I have a draft patch for this. It works fine on the examples you mentioned previously, but it complains about this:

if (missedCues[i].data()->startTime() < missedCues[i].data()->endTime())
    eventTasks.append(std::make_pair(missedCues[i].data()->endTime(),
                                     missedCues[i].data()));

I'm a bit confused. Is this false positive or not? Should we use braces in this case?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.