[Webkit-unassigned] [Bug 129598] Second execution of navigator.vibration() does not wok.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129598





--- Comment #12 from Jinwoo Jeong <jw00.jeong at samsung.com>  2014-03-05 19:35:16 PST ---
(In reply to comment #10)
> (From update of attachment 225923 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225923&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        If the vibrating starts with the VibrationPattern that has single element.
> 
> s/the/a, s/./,
Done.
> 
> > Source/WebCore/ChangeLog:9
> > +        m_isVibrating could not be set as false on Vibration::timerStopFired,
> 
> s/,/.
Done.
> 
> > Source/WebCore/Modules/vibration/Vibration.cpp:55
> >          return true;
> 
> You should not return here after canceling vibration. If a new vibration pattern is set, then existing vibration is canceled and the new vibration should work.

Yes, new vibration should work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.