[Webkit-unassigned] [Bug 129598] Second execution of navigator.vibration() does not wok.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 5 17:42:44 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=129598





--- Comment #10 from Jinwoo Song <jinwoo7.song at samsung.com>  2014-03-05 17:39:45 PST ---
(From update of attachment 225923)
View in context: https://bugs.webkit.org/attachment.cgi?id=225923&action=review

> Source/WebCore/ChangeLog:8
> +        If the vibrating starts with the VibrationPattern that has single element.

s/the/a, s/./,

> Source/WebCore/ChangeLog:9
> +        m_isVibrating could not be set as false on Vibration::timerStopFired,

s/,/.

> Source/WebCore/Modules/vibration/Vibration.cpp:55
>          return true;

You should not return here after canceling vibration. If a new vibration pattern is set, then existing vibration is canceled and the new vibration should work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list