[Webkit-unassigned] [Bug 129429] [Win32][LLINT] Crash when running JSC stress tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129429





--- Comment #30 from peavo at outlook.com  2014-03-04 12:34:45 PST ---
(In reply to comment #27)
> (From update of attachment 225791 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225791&action=review
> 

Thanks for reviewing :) Updated patch.

> > Source/WTF/wtf/WTFThreadData.h:99
> >          // We need to always get a fresh StackBounds from the OS due to how fibers work.
> >          // See https://bugs.webkit.org/show_bug.cgi?id=102411
> > -#if OS(WINDOWS)
> > +#if OS(WINDOWS) && !ENABLE(LLINT)
> >          m_stackBounds = StackBounds::currentThreadStackBounds();
> >  #endif
> >          return m_stackBounds;
> 
> I don't think we want to check ENABLE(LLINT) here. A Windows client can use fibers regardless of LLInt.

Can we avoid updating the stack bounds?
I reverted this in the latest patch, but I see now that it introduces more stress test errors.
Probably because it gives different results after stack memory is precommitted.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.