[Webkit-unassigned] [Bug 129363] Cursor and input text is not updating in vertical-rl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129363





--- Comment #9 from Sudarshan C P <sudarshan.cp at samsung.com>  2014-03-02 21:16:17 PST ---
(In reply to comment #8)
> (From update of attachment 225222 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225222&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Fix repaint rect for position element in writing mode.
> This is incorrect wording, you patch changes absolute positioned element behavior only.
> yes i agreed i will modify.
> > Source/WebCore/rendering/RenderBox.cpp:2109
> > +    if (isWritingModeRoot() && !fixed)
> 
> Not sure why absolute positioned elements would be an exception here. You should figure it out why it was originally introduced it here -> http://trac.webkit.org/changeset/71851/trunk/WebCore/rendering/RenderBox.cpp
> 

Analyzing more to find the root cause of this case.

> > Source/WebCore/rendering/RenderBox.cpp:4580
> > +        rect.setX(std::max(width().toFloat(), style().width().value()) - rect.maxX());
> 
> How does this help fix this case? -and why it is only for flipForWritingMode(LayoutRect& rect) and not for the other helpers like flipForWritingMode(FloatRect& rect)

In case of vertical mode,width of the container block gives 0 width,not considering the style width mentioned in the content,hence repaint rect is goes wrong, not updating properly,so added this condition.

Thanks for updating the comments, i will analyze more with respect to this,  and updating the new patch for this.
Please suggest me if any.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.