[Webkit-unassigned] [Bug 133605] [GTK] 8tracks.com triggers annoying pop-up window/installation of "About protocol source plugin" (GStreamer?)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 27 03:04:51 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=133605


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #233975|review?                     |review+
               Flag|                            |




--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-06-27 03:05:05 PST ---
(From update of attachment 233975)
View in context: https://bugs.webkit.org/attachment.cgi?id=233975&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:279
>      String cleanUrl(url);
>  
> +    if (kurl.isBlankURL())
> +        return;

That cleanUrl (that should be cleanURL) would be unused in case kurl is blank. Also, even if it was already there, I'm not sure kurl is a good name . . .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list