[Webkit-unassigned] [Bug 134347] Define TARGET_OS_IPHONE to 0 for non-darwin ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 26 11:39:20 PDT 2014


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #233904|review?                     |review+
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2014-06-26 11:39:38 PST ---
(From update of attachment 233904)
View in context: https://bugs.webkit.org/attachment.cgi?id=233904&action=review

It’s worth noting why this is different from our usual strategy. Unlike, say, WebCore, WebKit2 has public header files, and in public header files we need to use conditionals that don’t rely on WebKit internals such as Platform.h.

Understanding that leads to the thought that for EFL and GTK, this use of TARGET_OS_IPHONE in public header files might pose a problem, for the same reason that PLATFORM(IOS) would be a problem on the Mac and iOS platform. We may need to run a script to strip those out for those platforms as part of the “installing public headers” process.

> Source/WTF/wtf/Platform.h:1049
> +/* Set TARGET_OS_IPHONE to 0 by default to allow using it as a guard 
> + * in cross-platform the same way as it is used in OS(DARWIN) code */ 

Normally we’d put a period at the end of a sentence.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list