[Webkit-unassigned] [Bug 134294] Clean up the WebKit build from unused parameter warning in Webkit2/UIProcess module

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134294





--- Comment #9 from Rohit <kumar.rohit at samsung.com>  2014-06-25 23:30:21 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > As per the rule https://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html, we can omit parameter names for unused parameters entirely.
> > 
> > 
> > Yes, I tried that. But if we remove parameter name in function defintion then it shows error in check-webkit-style script.
> 
> I feel that error is reported, without these fix as well, if we just run check-webkit-style for the file APIUIClient.h, it lists similar errors in some other lines also, for these kind of parameter( std::function<void (unsigned long long)> completionHandler). so we can fix that space error as per coding idiom or check can it be ignored as per coding idiom.

Although I am not facing this space error if I don't omit parameter name, but I have cleaned up the warning using parameter name omission. I guess it happens because check-webkit-style script checks for only that particular statement where changes are made and hence it shows error only in that line and no other line in that file. For current patch I have ignored the warning.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.