[Webkit-unassigned] [Bug 133395] Web Inspector: debugger should be able to show variable types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133395


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #233743|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #22 from Filip Pizlo <fpizlo at apple.com>  2014-06-24 15:22:03 PST ---
(From update of attachment 233743)
View in context: https://bugs.webkit.org/attachment.cgi?id=233743&action=review

> Source/JavaScriptCore/runtime/HighFidelityLog.h:39
> +    class TypeLocation;

Unindent this.

> Source/JavaScriptCore/runtime/HighFidelityTypeProfiler.h:48
> +    typedef HashMap<String, RefPtr<TypeSet>> GlobalLocationMap; // (for now, hack it and say Map:"ID:Line" => TypeSet. Obviously, this assumes all assignments are on discrete lines).

This is pretty shady.  The key should be a struct.  Since that takes effort and this code uses few cycles, you can use std::unordered_map.

> Source/JavaScriptCore/runtime/HighFidelityTypeProfiler.h:50
> +    typedef HashMap<String, int64_t> GlobalLocationToGlobalIDMap;

Ditto.

> Source/JavaScriptCore/runtime/Structure.cpp:1071
> +        for (; iter != end; ++iter) {
> +            shape->addProperty(iter->key);
> +        }

No need for { and } if the body is just one line.  You can just say:

for (; iter != end; ++iter)
    shape->addProperty(iter->key);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.