[Webkit-unassigned] [Bug 133680] [GTK] WebKitWebView::create should receive information about the navigation action

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133680





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-06-24 10:52:06 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > Attachment 233708 [details] [details] did not pass style-queue:
> > 
> > 
> > WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h"
> > WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/webkit2.h"
> > WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitNavigationAction.h"
> > WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitNavigationPolicyDecision.h"
> > ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:63:  Extra space before ( in function call  [whitespace/parens] [4]
> > ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:69:  Extra space before ( in function call  [whitespace/parens] [4]
> > ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:74:  Extra space before ( in function call  [whitespace/parens] [4]
> > Total errors found: 3 in 25 files
> 
> Are these false-positives?

Yes, the style checker thinks they are function calls, but they are std::function parameters

std::function<void ()>, std::function<void (bool) and std::function<void (const String&)>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.