[Webkit-unassigned] [Bug 134246] REGRESSION(r170235): Remove incorrect ifdef guard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 24 10:35:37 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=134246





--- Comment #7 from Csaba Osztrogonác <ossy at webkit.org>  2014-06-24 10:35:57 PST ---
(In reply to comment #6)
> This breaks the build for all the platforms that do not enable HIDDEN_PAGE_DOM_TIMER_THROTTLING.
> You removed the #ifdef but you left it around the kit function on line 521.

In this case the original guarding was incorrect. This call was guarded with
"#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)".
But now there isn't PAGE_VISIBILITY_API guard, so we need this kit call
unconditionally. Should we remove guards around kit function core?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list