[Webkit-unassigned] [Bug 133850] HTML5 Gamepad API implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133850





--- Comment #4 from WebKit Commit Bot <commit-queue at webkit.org>  2014-06-24 07:32:48 PST ---
Attachment 233703 did not pass style-queue:


ERROR: Source/WebCore/Modules/gamepad/Gamepad.h:65:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/Gamepad.h:80:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/Gamepad.h:98:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/GamepadsProvider.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/efl/GamepadsProviderEfl.cpp:32:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:30:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:32:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:35:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:48:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:49:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:49:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:50:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/Modules/gamepad/GamepadEventController.cpp:110:  Missing space before ( in if(  [whitespace/parens] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.h:44:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.h:61:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.h:64:  The parameter name "gamepad" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.h:65:  The parameter name "gamepad" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/gtk/GamepadsProviderGtk.cpp:32:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/platform/gtk/GamepadsProviderGtk.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/gtk/GamepadsProviderGtk.cpp:87:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/Modules/gamepad/GamepadsManager.cpp:30:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadsManager.cpp:31:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadsManager.cpp:33:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.cpp:31:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.cpp:31:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.cpp:60:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.cpp:38:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.cpp:44:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.cpp:54:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.cpp:59:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadEvent.cpp:60:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:31:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/Gamepad.cpp:30:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/Gamepad.cpp:30:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/gamepad/Gamepad.cpp:69:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/Modules/gamepad/Gamepad.cpp:68:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/Gamepad.cpp:69:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadButton.h:51:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadButton.h:56:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadButton.h:73:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadButton.h:77:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/gamepad/GamepadButton.h:81:  Missing space before {  [whitespace/braces] [5]
Total errors found: 44 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.