[Webkit-unassigned] [Bug 133844] Removing PAGE_VISIBILITY_API compile guard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133844





--- Comment #4 from Éva Balázsfalvi <evab.u-szeged at partner.samsung.com>  2014-06-24 03:19:33 PST ---
(In reply to comment #3)
> (From update of attachment 233044 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233044&action=review
> 
> > Source/WebKit/mac/WebView/WebView.mm:4327
> > -#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
> > +#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
> >      if (_private->page)
> >          return kit(_private->page->visibilityState());
> >  #endif
> 
> This looks wrong, now the code will only run if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) is true.
> Shouldn't we remove the #if guard entirely here?

Good point, thanks for noticing,

Sorry, my bad. I've made a quick fix: https://bugs.webkit.org/show_bug.cgi?id=134246

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.