[Webkit-unassigned] [Bug 133844] Removing PAGE_VISIBILITY_API compile guard
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 23 19:00:25 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=133844
--- Comment #3 from Andreas Kling <akling at apple.com> 2014-06-23 19:00:42 PST ---
(From update of attachment 233044)
View in context: https://bugs.webkit.org/attachment.cgi?id=233044&action=review
> Source/WebKit/mac/WebView/WebView.mm:4327
> -#if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
> +#if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING)
> if (_private->page)
> return kit(_private->page->visibilityState());
> #endif
This looks wrong, now the code will only run if ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) is true.
Shouldn't we remove the #if guard entirely here?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list