[Webkit-unassigned] [Bug 133782] [WK2][EFL] Implement text selection range and url's copy and paste through EFL MiniBrowser Context Menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133782


Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #233351|review?                     |review-
               Flag|                            |




--- Comment #9 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-06-23 18:41:45 PST ---
(From update of attachment 233351)
View in context: https://bugs.webkit.org/attachment.cgi?id=233351&action=review

This patch is almost copied from GTK implementation. So, please consider my suggestion. So, r-

> Source/WebCore/ChangeLog:4
> +        Need the bug URL (OOPS!).

Remove this template.

> Source/WebCore/ChangeLog:7
> +

Missing patch description.

> Source/WebCore/platform/efl/DataObjectEfl.cpp:4
> +    This library is free software; you can redistribute it and/or

Use BSD instead of LGPL license.

> Source/WebCore/platform/efl/DataObjectEfl.h:20
> +#ifndef DataObjectEfl_h

It looks DataObjectGtk.h/cpp files are almost same with DataObjectGtk.h/cpp. In this case, you have to add *original author* in Licence. Besides I think we can share common functions with GTK port. So, we may make DataObject.h/cpp to be shared by GTK and EFL. Then, we make DataObjectGtk.h/cpp and DataObjectEfl.h/cpp to support port specific implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.