[Webkit-unassigned] [Bug 130638] [Win64] ASM LLINT is not enabled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130638





--- Comment #54 from peavo at outlook.com  2014-06-23 14:14:10 PST ---
(In reply to comment #52)
> (From update of attachment 233450 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233450&action=review
> 

Thanks for reviewing :)

> There are 2 slots that are unexplained and unaccounted for here.  Can you please explain what you're trying to achieve here (with the 2 slots)?  If I've misunderstood your reasoning in my comments above, please correct me.  Thanks.
> 

I believe we have to allocate another 2 slots for two more function parameters, since the call can have up to 6 parameters.
Updated the comment in the patch.

> > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:333
> > +        # We need to allocate 48 bytes on the stack; 32 bytes for the shadow space, and 8 bytes for the frame pointer we put on the stack,
> > +        # and 8 bytes for the function return address (which isn't really needed, so we only make room for it here).
> > +        subp 48, sp
> 
> This is wrong.  It should be "subp 32, sp".
> 

Thanks, fixed in latest patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.