[Webkit-unassigned] [Bug 121543] [GTK] Some of DOM bindings macros are misnamed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 06:39:35 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=121543





--- Comment #7 from Tomas Popela <tpopela at redhat.com>  2014-06-23 06:39:53 PST ---
(In reply to comment #6)
> (From update of attachment 233599 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233599&action=review
> 
> Great job! Thank you very much. This looks good to me. Martin, Gustavo, any objection?
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1419
> > -    return WEBKIT_DOM_${clsCaps}(g_object_new(WEBKIT_TYPE_DOM_${clsCaps}, "core-object", coreObject, NULL));
> > +    return WEBKIT_DOM_${clsCaps}(g_object_new(WEBKIT_DOM_TYPE_${clsCaps}, "core-object", coreObject, NULL));
> 
> We can take advantage we are changing this line to use nullptr instead of NULL.

No problem. Updated patch will follow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list