[Webkit-unassigned] [Bug 133028] Build break of 2.4.1 under mingw32/msys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133028





--- Comment #30 from Milan Crha <mcrha at redhat.com>  2014-06-22 23:07:41 PST ---
(In reply to comment #29)
> I tried building with JIT, but the symbol callToJavaScript is missing. It's
> defined for MSVC assembler, not gcc.

If you check the "Depends on" above, then you'll find more than this bug report fixes, I split them. The bug #132856 contains assembler implementation of the missing functions for gcc.

> +#if OS(WINDOWS)
> +        bufferPrintf("#0x%I64x", immediate);
> +#else
>         bufferPrintf("#0x%llx", immediate);
> +#endif

This is wrong, I64 is an MSVC format specifier, not gcc, thus OS(WINDOWS) check is not sufficient for correct behaviour.

Some of your changes clashes with those mine, either here, or from the "Depends On" bugs. I believe having a clean patches only with newly added changes will help with application of them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.