[Webkit-unassigned] [Bug 133923] Web Inspector: Inspecting <aside> produces wrong highlight rectangle.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133923





--- Comment #5 from Zalan Bujtas <zalan at apple.com>  2014-06-22 18:13:33 PST ---
(In reply to comment #2)
> The inspector highlight information comes from the renderer. The RenderBox for the <aside> seems to say it is huge. renderBox->marginRight() is 31104.
> 
> lldb> f
> frame #0: 0x00000001142908c5 WebCore`WebCore::(anonymous namespace)::buildRendererHighlight(renderer=0x00007ff8d17ad960, region=0x0000000000000000, highlightConfig=0x00007ff8d141d970, highlight=0x00007fff54751e80) + 741 at InspectorOverlay.cpp:141
>    138     
>    139                 LayoutBoxExtent margins(renderBox->marginTop(), renderBox->marginRight(), renderBox->marginBottom(), renderBox->marginLeft());
>    140     
> -> 141                 if (!renderBox->isOutOfFlowPositioned() && region) {
>    142                     RenderBox::LogicalExtentComputedValues computedValues;
>    143                     renderBox->computeLogicalWidthInRegion(computedValues, region);
>    144                     margins.mutableLogicalLeft(renderBox->style().writingMode()) = computedValues.m_margins.m_start;
> 
> 
> lldb> p *renderBox
> ...
>   m_frameRect = {
>     m_location = {
>       m_x = (m_value = 31296)
>       m_y = (m_value = 192)
>     }
>     m_size = {
>       m_width = (m_value = 19712)
>       m_height = (m_value = 5760)
>     }
>   }
>   m_marginBox = {
>     m_top = (m_value = 0)
>     m_right = (m_value = 31104)
>     m_bottom = (m_value = 0)
>     m_left = (m_value = 0)
>   }
> ...
You don't seem to have the LayoutUnit <-> CSS px conversion lldb helper applied. 31296 is 489px which looks to me like normal right margin value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.