[Webkit-unassigned] [Bug 134106] [Win] Menu list theme is not drawn.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134106





--- Comment #3 from peavo at outlook.com  2014-06-20 11:25:29 PST ---
(In reply to comment #2)
> (From update of attachment 233429 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233429&action=review
> 

Thanks for looking into this :)

> > Source/WebCore/rendering/RenderThemeWin.cpp:803
> > +    adjustMenuListButtonStyle(*styleResolver, *style, *e);
> 
> I think RenderTheme::adjustStyle should be changed to pass references instead of pointers so we don't have to dereference unchecked pointers into references here.

I agree, could we perhaps address this in a separate patch, since it's a bigger change, involving all platforms?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.