[Webkit-unassigned] [Bug 133572] Using --recordGCPauseTimes=true causes a crash in jsc.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133572





--- Comment #10 from Tamas Gergely <tgergely.u-szeged at partner.samsung.com>  2014-06-20 05:50:41 PST ---
(In reply to comment #9)
> (From update of attachment 233306 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233306&action=review
> 
> > Source/JavaScriptCore/jsc.cpp:1251
> > +    static std::once_flag optionDependentInitOnceFlag;
> > +    std::call_once(optionDependentInitOnceFlag, [] {
> 
> Since this is main, there's no need for call_once-style thread-safety.
> 
> > Source/JavaScriptCore/runtime/InitializeThreading.cpp:-62
> > -        if (Options::recordGCPauseTimes())
> > -            HeapStatistics::initialize();
> 
> I don't think we want to remove this from the generic initialization path, because that would make it not work in WebKit.

Ok. Then I'll try another solution: make HeapStatistics::initialize() smarter to handle multiple calls. Should we handle the rare situation when the option is set from environment variable and cleared from command line? If not, we will create two unused Vectors on the heap in this situation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.