[Webkit-unassigned] [Bug 133726] [GTK] Limit the amount of API exposed to GObject DOM bindings API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133726





--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-06-19 22:47:03 PST ---
(In reply to comment #14)
> (From update of attachment 233227 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233227&action=review
> 
> LGTM!

Thanks for the review!

> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:980
> >      # Insert introspection annotations
> > -    push(@hBody, "/**\n");
> > -    push(@hBody, " * ${functionName}:\n");
> > -    push(@hBody, " * \@self: A #${className}\n");
> > +    push(@functionHeader, "/**");
> > +    push(@functionHeader, " * ${functionName}:");
> > +    push(@functionHeader, " * \@self: A #${className}");
> 
> You don't need to provide the newlines anymore?

No, because I'm doing join("\n", @functionHeader) below

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.