[Webkit-unassigned] [Bug 134070] [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134070





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2014-06-19 14:20:17 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 233376 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=233376&action=review


> > Wouldn't it be easier to simply run Xvfb with the JHBuild wrapper? Doesn't the PATH take care of choosing the correct Xvfb?
> 
> I wasn't sure about what would happen if jhbuild is not installed and you try to run Xvfb with the wrapper, so I opted for only doing that when it is installed.
> 
> I will modify this if you think it would work ok.

If you run Xvfb with self._jhbuild_wrapper is seems like you shouldn't need to modify the path at all.

> > > Tools/Scripts/webkitpy/port/xvfbdriver.py:99
> > > +        if os.path.exists(self._port.path_from_webkit_base('WebKitBuild', 'Dependencies')):
> > > +                # Run the Xvfb from the jhbuild
> > > +                run_xvfb = self._port._jhbuild_wrapper + run_xvfb
> > 
> > We don't have any helpers for this?
> > 
> 
> Helpers for what?

Helper for detecting if JHBuild is used. It looks like gtk.py uses the same approach. If we do this more than once it needs to be in a helper called something like "should_use_jhbuild."
> 
> > > Tools/Scripts/webkitpy/port/xvfbdriver.py:107
> > > +        if self._llvmpipe_libgl_path:
> > > +                # Force the Gallium llvmpipe software rasterizer
> > > +                environment['LD_LIBRARY_PATH'] = self._llvmpipe_libgl_path
> > > +                # If there were another paths on LD_LIBRARY_PATH append them after llvmpipe_libgl_path
> > > +                if os.environ.get('LD_LIBRARY_PATH'):
> > > +                        environment['LD_LIBRARY_PATH'] += ':%s' % os.environ.get('LD_LIBRARY_PATH')
> > > +
> > 
> > Can't we set this up in gtk.py? Your indentation is also a bit funky.
> 
> I think is a bad idea for the reasons explained above. The preload of mesa should only happen for the Xvfb driver and not for the others.

It isn't possible to reuse setup_environ_for_server or to create a setup_environ_for_xvfb in gtk.py? I don't think we should be doing GTK+ specific things in this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.