[Webkit-unassigned] [Bug 134042] Don't kill the UIProcess until all local storage transactions have been committed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=134042


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #233354|review?                     |review+
               Flag|                            |




--- Comment #8 from Anders Carlsson <andersca at apple.com>  2014-06-19 11:55:33 PST ---
(From update of attachment 233354)
View in context: https://bugs.webkit.org/attachment.cgi?id=233354&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:597
> +        HashMap<std::pair<RefPtr<IPC::Connection>, uint64_t>, RefPtr<StorageArea>> storageAreasByConnection = m_storageAreasByConnection;

No need to copy the HashMap here.

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:598
> +        for (HashMap<std::pair<RefPtr<IPC::Connection>, uint64_t>, RefPtr<StorageArea>>::const_iterator it = storageAreasByConnection.begin(), end = storageAreasByConnection.end(); it != end; ++it) {

This should use a modern for loop.

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:604
> +        for (size_t i = 0; i < connectionAndStorageMapIDPairsToRemove.size(); ++i)
> +            m_storageAreasByConnection.remove(connectionAndStorageMapIDPairsToRemove[i]);

This should use a modern for loop, and I think a comment stating that removing the storage areas causes the changes to be flushed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.