[Webkit-unassigned] [Bug 133620] Add support for HTMLImageElement's sizes attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133620





--- Comment #30 from Sam Weinig <sam at webkit.org>  2014-06-18 22:25:06 PST ---
(From update of attachment 232884)
View in context: https://bugs.webkit.org/attachment.cgi?id=232884&action=review

> Source/WebCore/css/SourceSizeList.cpp:42
> +    expList->append(m_mediaExp.release());
> +    m_mediaExp = nullptr;

Is this necessary, given that you just called release() on the m_mediaExp I would expect it to be null.

> Source/WebCore/css/SourceSizeList.cpp:46
> +    mediaQuerySet->addMediaQuery(std::make_unique<MediaQuery>(mediaQuery));

This seems odd. Why did you create MediaQuery on the stack, just to copy it into this unique_ptr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.