[Webkit-unassigned] [Bug 133395] Web Inspector: debugger should be able to show variable types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133395





--- Comment #13 from Filip Pizlo <fpizlo at apple.com>  2014-06-18 08:36:26 PST ---
(From update of attachment 233308)
View in context: https://bugs.webkit.org/attachment.cgi?id=233308&action=review

Looks like you've got a lot of reverting to do! ;-)

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj.orig:13
> +// !$*UTF8*$!
> +{
> +	archiveVersion = 1;
> +	classes = {
> +	};
> +	objectVersion = 46;
> +	objects = {
> +
> +/* Begin PBXAggregateTarget section */
> +		0F4680A914BA7FD900BFE272 /* LLInt Offsets */ = {
> +			isa = PBXAggregateTarget;
> +			buildConfigurationList = 0F4680AC14BA7FD900BFE272 /* Build configuration list for PBXAggregateTarget "LLInt Offsets" */;
> +			buildPhases = (

I don't think you meant to add this file.

> Source/JavaScriptCore/bytecode/BytecodeUseDef.h:64
> -    case op_create_activation: 
> +    case op_create_activation:

Revert.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:115
> -    
> +

Revert.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:293
> -    
> +

Revert.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:296
> -    
> +
>      PropertyOffset offset = structure->getConcurrently(exec->vm(), ident.impl());

Revert.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1492
> -    RefPtr<RegisterID> func = newTemporary(); 
> +    RefPtr<RegisterID> func = newTemporary();

Revert.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1504
> -    emitOpcode(op_create_this); 
> -    instructions().append(m_thisRegister.index()); 
> -    instructions().append(func->index()); 
> +    emitOpcode(op_create_this);
> +    instructions().append(m_thisRegister.index());
> +    instructions().append(func->index());

Revert.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.