[Webkit-unassigned] [Bug 133572] Using --recordGCPauseTimes=true causes a crash in jsc.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133572





--- Comment #7 from Tamas Gergely <tgergely.u-szeged at partner.samsung.com>  2014-06-18 06:21:43 PST ---
(In reply to comment #5)
> (From update of attachment 233222 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233222&action=review
> 
> > Source/JavaScriptCore/ChangeLog:12
> > +        This is because JSC::initializeThreading() initializes HeapStatistics
> > +        before Options values get filled from the command line arguments, while
> > +        this initialization is dependent on the options.
> 
> I see a call to Options::recordGCPauseTimes(). Why is that not sufficient to fill in Options values from command line arguments?

Because Options::initialize() in the previous line initializes the options to their default values *without checking the command line*. The call to Options::recordGCPauseTimes() returns false here as it is the default value, so the HeapStatistics::initialize() is not called. Command line arguments are processed by the construction of a CommandLine object in the beginning of the jscmain(), but it was too late: we missed the call of HeapStatistics::initialize().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.