[Webkit-unassigned] [Bug 130941] [ATK] No accessible caret-moved events in a href display:block in div

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=130941


Jarek Czekalski <jarekczek at poczta.onet.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #233237|                            |review?
               Flag|                            |




--- Comment #5 from Jarek Czekalski <jarekczek at poczta.onet.pl>  2014-06-17 10:07:33 PST ---
Created an attachment (id=233237)
 --> (https://bugs.webkit.org/attachment.cgi?id=233237&action=review)
fix caret in a block, v1.00

Hello again, Mario!

I'm attaching another short patch. Please consider whether the suggested solution is correct.

It would be cleaner to use renderer()->isBlock instead of !renderer()->isInline(), but only the latter syntax may be easily merged into stable branch.

After this patch yelp title page becomes accessible in webkit1. I'm planning to ask for stable branch merge for this patch, which should be applied after:
1. Bug #132527
2. the hot fix for the above patch (contained in the ticket)
3. Bug #132349
4. Bug #130941 (the one here)

These patches apply almost cleanly to the stable branch, a small adjustment is needed for the first one.

Thanks in advance for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.