[Webkit-unassigned] [Bug 121543] [GTK] Some of DOM bindings macros are misnamed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121543





--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-06-16 04:33:25 PST ---
(In reply to comment #1)
> We have some exceptions in the function decamelize, but not all cases are covered. While working on bug #121538 I also noticed an inconsistency in the macros for the WebKitDOMObject and all others, see:
> 
> WEBKIT_TYPE_DOM_OBJECT
> WEBKIT_IS_DOM_OBJECT
> WEBKIT_IS_DOM_OBJECT_CLASS
> 
> While all other generated objects have WEBKIT_DOM as the prefix, for example:
> 
> WEBKIT_TYPE_DOM_ATTR
> WEBKIT_DOM_IS_ATTR
> WEBKIT_DOM_IS_ATTR_CLASS
> 
> So, we are always using WEBKIT as the prefix for TYPE macros, but WEBKIT_DOM for IS macros except for WebKitDOMObject that we use WEBKIT. 
> 
> I think we should fix all these inconsistencies and provide backwards compatibility macros in WebKitDOMCustom.

To make it clear, since we are using WebKitDOM as our namespace I think we should rename all TYPE macros as WEBKIT_DOM_TYPE_FOO and WebKitDOMObject macros as well. Unless I'm wrong and the intention was not to use WebKitDOM as the namespace. Maybe Gustavo or Martin know it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.