[Webkit-unassigned] [Bug 133796] ASSERT_NOT_REACHED() in WebCore::fontWeightIsBold

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133796





--- Comment #6 from Zalan Bujtas <zalan at apple.com>  2014-06-12 13:08:38 PST ---
(From update of attachment 232953)
View in context: https://bugs.webkit.org/attachment.cgi?id=232953&action=review

> Source/WebCore/editing/EditingStyle.cpp:1516
>  static bool fontWeightIsBold(CSSValue* fontWeight)

This should take CSSValue&.

> Source/WebCore/editing/EditingStyle.cpp:1551
> +static bool fontWeightNeedsResolving(CSSValue* fontWeight)

This should take CSSValue& too.

> Source/WebCore/editing/EditingStyle.cpp:1574
> +    if (RefPtr<CSSValue> baseFontWeight = extractPropertyValue(baseStyle, CSSPropertyFontWeight)) {
> +        if (RefPtr<CSSValue> fontWeight = mutableStyle->getPropertyCSSValue(CSSPropertyFontWeight)) {
> +            if (!fontWeightNeedsResolving(fontWeight.get()) && (fontWeightIsBold(fontWeight.get()) == fontWeightIsBold(baseFontWeight.get())))

I can't comment on the correctness of this, but surely you could shave off at least one level of nesting here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.