[Webkit-unassigned] [Bug 133730] [GTK] Introduce a new WebKitUserContent API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133730





--- Comment #4 from Adrian Perez <aperez at igalia.com>  2014-06-12 07:17:39 PST ---
(In reply to comment #2)
> Created an attachment (id=232952)
 --> (https://bugs.webkit.org/attachment.cgi?id=232952&action=review) [details]
> Patch

Notes about this first version of the patch:

 - **Not ready** for landing.

 - The main idea is to use it to start reviewing the new API for
   WebKitUserContentManager, WebKitUserContent, WebKitUserScript,
   and WebKitUserStyleSheet.

 - The actual implementation is WIP and though the bits to support
   the new classes should be mostly ready, the code to attach an
   WebKitUserContentManager and for handling the user script 
   messages (in ScriptMessageClientGtk) are missing.

What I am most interested for the moment is having a second pair
of eyes review the new bits of the API.

As for attaching a WebKitUserContentManager to a web view, my plan
so far is to:

 - Add webkit_web_view_new_with_user_content_manager(view, manager).
   Views created with the other functions will have a default
   WebKitUserContentManager.

 - Add webkit_web_view_get_user_content_manager(view).

One doubt I have is: when creating a related web view (by means of
webkit_web_view_new_with_related_view()), does the new related web
view use the same WebKitUserContentManager, or would it get a fresh
one? If the correct thing to do is the later, would we also add a
webkit_web_view_new_with_related_view_and_user_content_manager()
function?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.