[Webkit-unassigned] [Bug 133780] [GTK] Performance tests should be always ran with WKTR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133780


Manuel Rego Casasnovas <rego at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232926|commit-queue?               |commit-queue+
               Flag|                            |




--- Comment #5 from Manuel Rego Casasnovas <rego at igalia.com>  2014-06-12 05:23:30 PST ---
(From update of attachment 232926)
View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review

>>>> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71
>>>> +            self._options.webkit_test_runner = True
>>> 
>>> Should we split out some warning about this?
>> 
>> For example right now "run-launcher --gtk -2" fails and returns:
>> Starting webkit launcher.
>> Cannot parse arguments: Unknown option -2
>> 
>> I don't know what's the best approach, maybe simply showing a warning and using always WebKit2 is the best option.
>> But I think we should be consistent and do the same in: run-launcher, run-webkit-tests and run-perf-tests. Of course, this can be done in different patches.
> 
> The bots are going to keep passing "--webkit-test-runner/-2" because that is how are implemented the steps on Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg Making it fail when "-2/--webkit-test-runner" is passed will break the bots.
> 
> And I'm not sure about the usefulness of showing a warning. run-webkit-tests also uses WKTR always with GTK+ and no warning is shown: <http://trac.webkit.org/changeset/167426>. So I think the current patch is consistent with that.

Ok, fair enough. I didn't realize run-webkit-tests was fixed already.

Maybe we could change run-launcher to use WebKit2 by default and not fail (maybe showing a warning in that particular case).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.