[Webkit-unassigned] [Bug 133780] [GTK] Performance tests should be always ran with WKTR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133780


Manuel Rego Casasnovas <rego at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |berto at igalia.com,
                   |                            |cgarcia at igalia.com,
                   |                            |mrobinson at webkit.org,
                   |                            |pnormand at igalia.com,
                   |                            |rego at igalia.com,
                   |                            |svillar at igalia.com,
                   |                            |zandobersek at gmail.com




--- Comment #3 from Manuel Rego Casasnovas <rego at igalia.com>  2014-06-12 00:18:44 PST ---
(In reply to comment #2)
> (From update of attachment 232926 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232926&action=review
> 
> > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:71
> > +        # The GTK+ port only supports WebKit2, so it always uses WKTR.
> > +        if self._port.name().startswith("gtk"):
> > +            self._options.webkit_test_runner = True
> 
> Should we split out some warning about this?

For example right now "run-launcher --gtk -2" fails and returns:
Starting webkit launcher.
Cannot parse arguments: Unknown option -2

I don't know what's the best approach, maybe simply showing a warning and using always WebKit2 is the best option.
But I think we should be consistent and do the same in: run-launcher, run-webkit-tests and run-perf-tests. Of course, this can be done in different patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.