[Webkit-unassigned] [Bug 133667] Don't snapshot offscreen plugins that would normally be considered primary plugins after they are moved in view

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133667


Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at webkit.org




--- Comment #9 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-06-11 23:03:55 PST ---
(In reply to comment #8)
> (In reply to comment #6)
> > (From update of attachment 232886 [details] [details])
> > Clearing flags on attachment: 232886
> > 
> > Committed r169820: <http://trac.webkit.org/changeset/169820>
> 
> It broke the !ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC) builds:
> 
> /home/webkit/WebKit/Source/WebKit2/WebProcess/Plugins/PluginView.cpp: In member function 'void WebKit::PluginView::pluginSnapshotTimerFired()':
> /home/webkit/WebKit/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1693:40: error: 'class WebKit::WebPage' has no member named 'plugInIntersectsSearchRect'
> /home/webkit/WebKit/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1707:96: error: 'isAlmostSolidColor' was not declared in this scope
> /home/webkit/WebKit/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1721:20: error: 'class WebKit::WebPage' has no member named 'plugInIsPrimarySize'

I file a bug to fix this error.
https://bugs.webkit.org/show_bug.cgi?id=133786

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.