[Webkit-unassigned] [Bug 133562] Add SPI for Injected Bundle to provide user agent for a given URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133562


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232869|review?                     |review-
               Flag|                            |




--- Comment #11 from Anders Carlsson <andersca at apple.com>  2014-06-11 14:08:00 PST ---
(From update of attachment 232869)
View in context: https://bugs.webkit.org/attachment.cgi?id=232869&action=review

Looks good overall! I think you need to rebase the patch against ToT and address my review comments.

> Source/WebKit2/ChangeLog:435
> +2014-06-05  Grant Kennell  <gkennell at apple.com>

This entry should be moved to the top of the ChangeLog.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:409
> +    WKBundlePageUserAgentForURLCallback                                     userAgentForURL;
>  } WKBundlePageLoaderClientV7;

I think you need to add a new struct version here.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:467
> +    WKBundlePageUserAgentForURLCallback                                     userAgentForURL;
>  } WKBundlePageLoaderClient WK_DEPRECATED("Use an explicit versioned struct instead");

You don't need to add this to the deprecated client.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:363
> +    WKStringRef userAgent = m_client.userAgentForURL(toAPI(frame), toAPI(url.get()), m_client.base.clientInfo);

This needs to go into a WKRetainPtr or it will be leaked.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:103
> +    API::String* userAgentForURL(WebFrame*, API::String*);

I think this should return a RefPtr<API::String>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.