[Webkit-unassigned] [Bug 133715] [EFL][WK2] Add missing test cases for EWK2ViewTest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133715


Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232858|review?                     |review+
               Flag|                            |




--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-06-11 03:31:20 PST ---
(From update of attachment 232858)
View in context: https://bugs.webkit.org/attachment.cgi?id=232858&action=review

LGTM except for minor nits.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:414
> +

Unnecessary line.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1052
> +    EXPECT_FALSE(ewk_view_page_contents_get(webView(), (Ewk_Page_Contents_Type) 2, PageContentsAsStringCallback, 0));

Use static_cast<Ewk_Page_Contents_Type> instead of (Ewk_Page_Contents_Type).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.