[Webkit-unassigned] [Bug 133620] Add support for HTMLImageElement's sizes attribute
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 9 22:41:58 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=133620
Sam Weinig <sam at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #232729|review? |review-
Flag| |
--- Comment #22 from Sam Weinig <sam at webkit.org> 2014-06-09 22:42:20 PST ---
(From update of attachment 232729)
View in context: https://bugs.webkit.org/attachment.cgi?id=232729&action=review
> Source/WebCore/css/MediaList.cpp:126
> -
> +
This change seems extraneous.
> Source/WebCore/css/MediaList.h:55
> -
> +
The changes to this file seem extraneous.
> Source/WebCore/css/SourceSizeList.h:37
> + SourceSize(MediaQueryExp* mediaExp, const CSSParserValue& length)
This should take a std::unique_ptr<MediaQueryExp> and move it into m_mediaExp.
> Source/WebCore/css/SourceSizeList.h:53
> + void append(SourceSize* sourceSize)
This should take a std::unique_ptr<SourceSize> and move it onto the Vector.
> Source/WebCore/css/SourceSizeList.h:62
> + Vector<std::unique_ptr<SourceSize> > m_list;
No need for the space between > and >
> Source/WebCore/html/HTMLImageElement.cpp:130
> +#if ENABLE_PICTURE_SIZES
We do ENABLE testing using the form #if ENABLE(PICTURE_SIZES). This is repeated a bunch.
> Source/WebCore/html/parser/HTMLSrcsetParser.cpp:235
> + candidate.density = (float)candidate.resourceWidth / (float)sourceSize;
Please use c++ style casts.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list