[Webkit-unassigned] [Bug 132349] AX: [ATK] text inside span block in a block not accessible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132349





--- Comment #3 from Mario Sanchez Prada <mario at webkit.org>  2014-06-09 02:34:30 PST ---
(From update of attachment 232681)
View in context: https://bugs.webkit.org/attachment.cgi?id=232681&action=review

The patch looks good to me, but I have a suggestion to improve the test before landing. See below...

> LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block.html:14
> +    <span style="display:block;">text1</span>

I think it would be interesting to place some text before and after the <span> *and* inside the scope of the <a> elements (for all the three cases), and then check that the full text (including the text inside the span and those 'before' and 'after' bits) will be returned when calling element.stringValue.

The purpose of this suggestion  is to ensure that the implementation of AtkText for those links whose children are not inline (because of the 'display: block' thing) is still returning the full 'flattened' text for all the block children (the 'before' and 'after' will be part of generated block elements) inside of it.

Other than this (and assuming that that extended version of the test will still pass), I don't have any other comment on the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.