[Webkit-unassigned] [Bug 133521] iOS8 media controls look different from iOS7 media controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133521





--- Comment #14 from Wenson Hsieh <wenson_hsieh at apple.com>  2014-06-05 20:11:18 PST ---
(From update of attachment 232589)
View in context: https://bugs.webkit.org/attachment.cgi?id=232589&action=review

Thanks! There will be another update in a few minutes.

>> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:26
>> +    min-width: 260px;
> 
> Nit: odd spacing, is there a tab in here?

hmm...I'm not sure I see the tab

>> LayoutTests/platform/ios-sim/media/audio-width.html:30
>> +            console.log("testing...");
> 
> console.log() doesn't end up in the results.

Oops...forgot to take out some debugging information. Good catch.

>> LayoutTests/platform/ios-sim/media/audio-width.html:33
>> +            var audioPath = "../../../media/" + findMediaFile("audio", "content/test");
> 
> But: I think you can include the "../../" in the path passed to findMediaFile.

got it. Fixed.

>> LayoutTests/platform/ios-sim/media/audio-width.html:36
>> +            runTest();
> 
> Nit: this doesn't necessarily have to be a separate function.

Contents of runTest moved here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.