[Webkit-unassigned] [Bug 133521] iOS8 media controls look different from iOS7 media controls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133521





--- Comment #8 from Tim Horton <thorton at apple.com>  2014-06-05 19:30:39 PST ---
(From update of attachment 232589)
View in context: https://bugs.webkit.org/attachment.cgi?id=232589&action=review

> Source/WebCore/ChangeLog:3
> +        iOS8 media controls look different from iOS7 media controls. Adjusted CSS to make media elements more similar to iOS7 by adding padding, adjusting hues/svg, resizing elements, etc.

Please reword as discussed on IRC.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:88
> +    background-color: rgb(0, 0, 0);

You could use the "black" keyword here.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:102
> +    -webkit-mask-image: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 42 44"><g fill="none"><path stroke="white" stroke-width="1" d="M15,27.5  10.5,27.5  10.5,14.5  30.5,14.5  30.5,27.5  26,27.5  30.5,27.5  30.5,14.5  10.5,14.5  10.5,27.5  15,27.5 Z" /><path fill="white" d="M20.5,23.5  13,31.5  28,31.5" /></g></svg>');

There are more spaces between path data elements in this one and the one above than the others. Intentional?

> LayoutTests/platform/ios-sim/media/audio-width.html:1
> +

There's an extra newline here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.