[Webkit-unassigned] [Bug 133483] [Curl] Empty headers in request response.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133483





--- Comment #5 from Alex Christensen <achristensen at apple.com>  2014-06-05 10:05:16 PST ---
(From update of attachment 232553)
View in context: https://bugs.webkit.org/attachment.cgi?id=232553&action=review

> Source/WebCore/ChangeLog:13
> +        This can be fixed by only letting the first request write to the content file.

Does this also protect against another process writing to the file?

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:142
> +        std::unique_ptr<CurlCacheEntry> cacheEntry(new CurlCacheEntry(url, 0, m_cacheDir));

This 0 should be a nullptr.  Also, try using std::make_unique instead of new.

> Source/WebCore/platform/network/curl/CurlCacheManager.cpp:219
> +        std::unique_ptr<CurlCacheEntry> cacheEntry(new CurlCacheEntry(url, job, m_cacheDir));

make_unique

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.