[Webkit-unassigned] [Bug 133510] [MediaStream] MediaStream.addTrack should not check for tracks ended state.

Wed Jun 4 09:18:42 PDT 2014

https://bugs.webkit.org/show_bug.cgi?id=133510

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232476|review?, commit-queue?      |review+
               Flag|                            |

--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2014-06-04 09:19:04 PST ---
(From update of attachment 232476)
View in context: https://bugs.webkit.org/attachment.cgi?id=232476&action=review

If you address the comments, fill in the "Reviewed by" in each ChangeLog, and upload the new patch WITHOUT orphaning the old version, you don't need another review and any reviewer will mark it cq+.

> Source/WebCore/ChangeLog:14
> +        (WebCore::MediaStreamPrivate::addTrack):

Nit: I think it is helpful to have a comment about what changed.

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

Nit: you should use an HTML5 doctype here: "<!DOCTYPE html>"

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:7
> +
> +

Nit: you have an extra blank line.

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:10
> +

Ditto.

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:41
> +

Ditto.

> LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:50
> +

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.