[Webkit-unassigned] [Bug 131515] Inlining native functions into the JavaScript in the FTL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131515


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232447|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #39 from Filip Pizlo <fpizlo at apple.com>  2014-06-03 16:08:40 PST ---
(From update of attachment 232447)
View in context: https://bugs.webkit.org/attachment.cgi?id=232447&action=review

> LayoutTests/js/regress/script-tests/ftl-library-inlining-dataview.js:13
> +    result = foo(new DataView(new ArrayBuffer(5)));

It would be far better to make this a result += foo..., so that your checking incorporates results from runs 0 through 3999999 and not just the last run.

> LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js:15
> +    try { 
> +        foo(i < count - 1000 ? new Date() : "a");
> +        x = false;
> +    } catch (e) {
> +        x = true;
> +    }

Ditto.  You could have a result that is computed by adding up the x's.

> LayoutTests/js/regress/script-tests/ftl-library-inlining-folding.js:14
> +    result = foo();

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.