[Webkit-unassigned] [Bug 131515] Inlining native functions into the JavaScript in the FTL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=131515


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #232445|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #37 from Filip Pizlo <fpizlo at apple.com>  2014-06-03 15:40:38 PST ---
(From update of attachment 232445)
View in context: https://bugs.webkit.org/attachment.cgi?id=232445&action=review

> LayoutTests/ChangeLog:13
> +        * js/regress/script-tests/ftl-library-inlining.js: Added.
> +        * js/regress/script-tests/ftl-library-inlining-dataview.js: Added.
> +        * js/regress/script-tests/ftl-library-inlining-exceptions.js: Added.
> +        * js/regress/script-tests/ftl-library-inlining-folding.js: Added.
> +        * js/regress/script-tests/ftl-library-inlining-loops.js: Added.

These tests should check errors.

> Source/JavaScriptCore/runtime/BundlePath.h:34
> +const CString * bundlePath();

Change this to simply return const CString& or even just CString.  Or a const char*.

Returning a const CString* is weird.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.